Skip to content

OTA-1836: chore(deps): Bump general OpenShift dependencies#1377

Open
DavidHurta wants to merge 2 commits intoopenshift:mainfrom
DavidHurta:bump-openshift-api
Open

OTA-1836: chore(deps): Bump general OpenShift dependencies#1377
DavidHurta wants to merge 2 commits intoopenshift:mainfrom
DavidHurta:bump-openshift-api

Conversation

@DavidHurta
Copy link
Copy Markdown
Contributor

@DavidHurta DavidHurta commented Apr 16, 2026 •
edited by coderabbitai Bot
Loading

The API update is needed for the new TLS adherence API and other efforts.

Other general openshift packages are updated as well for periodic maintenance. We might as well update those while we are at it. De facto an updated clone of the #1346 PR.

Generated by:

$ go get github.com/openshift/api@master
$ go get github.com/openshift/client-go@master
$ go get github.com/openshift/library-go@master
$ go mod tidy
$ go mod vendor
$ git add -A go.* vendor

using:

$ go version
go version go1.25.0 linux/amd64

Summary by CodeRabbit

  • Chores
    • Updated OpenShift Go dependencies to newer versions for improved compatibility and stability.
  • Tests
    • Improved an integration test to be more resilient by waiting for leader-election events with retries, reducing intermittent failures.

@DavidHurta
chore(deps): Bump general openshift dependencies
28e62a8 
The API update is needed for the new TLS adherence API and
other efforts.

Other general openshift packages are updated as well for periodic
maintenance. We might as well update those while we are at it.

Generated by:

```
$ go get github.com/openshift/api@master
$ go get github.com/openshift/client-go@master
$ go get github.com/openshift/library-go@master
$ go mod tidy
$ go mod vendor
$ git add -A go.* vendor
```

using:

```
$ go version
go version go1.25.0 linux/amd64
```
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 16, 2026
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Apr 16, 2026 •
edited by openshift-ci Bot
Loading

@DavidHurta: This pull request references OTA-1836 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target either version "5.0." or "openshift-5.0.", but it targets "openshift-4.22" instead.

Details

In response to this:

The API update is needed for the new TLS adherence API and other efforts.

Other general openshift packages are updated as well for periodic maintenance. We might as well update those while we are at it. De facto a clone of the #1346 PR.

Generated by:

$ go get github.com/openshift/api@master
$ go get github.com/openshift/client-go@master
$ go get github.com/openshift/library-go@master
$ go mod tidy
$ go mod vendor
$ git add -A go.* vendor

using:

$ go version
go version go1.25.0 linux/amd64

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 16, 2026 •
edited by openshift-ci Bot
Loading

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 4a84fbed-70d4-4f6b-9eea-cac6c5a8601e

📥 Commits

Reviewing files that changed from the base of the PR and between 28e62a8 and 2ff8337.

📒 Files selected for processing (1)
  • pkg/start/start_integration_test.go

Walkthrough

Updated three OpenShift Go dependency pseudo-versions in go.mod from 202603* to 202604*; adjusted integration test TestIntegrationCVO_gracefulStepDown to poll the Kubernetes Events API until a leader-election event appears (or the 10s context times out) instead of failing on a single read.

Changes

Cohort / File(s) Summary
OpenShift Dependency Updates
go.mod		 Bumped github.com/openshift/api, github.com/openshift/client-go, and github.com/openshift/library-go from 202603* to 202604* pseudo-versions in the require block.
Integration test: event polling
pkg/start/start_integration_test.go		 TestIntegrationCVO_gracefulStepDown now polls Events().List until hasLeaderEvent(events.Items, ns) returns true or the 10s context expires; transient Events().List errors abort the poll via returned error.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

🚥 Pre-merge checks | ✅ 10 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Test Structure And Quality ⚠️ Warning Test changes lack descriptive failure messages in error assertions; bare t.Fatal(err) calls reduce debuggability for integration test timeout failures. Add contextual messages to error handling, e.g., t.Fatalf("failed to detect leader election event in %s: %v", ns, err).
✅ Passed checks (10 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'OTA-1836: chore(deps): Bump general OpenShift dependencies' directly and clearly describes the main change—updating OpenShift Go module dependencies to their master branches.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The modified test file uses standard Go testing framework, not Ginkgo. No Ginkgo test definitions found, so custom check for stable test names is not applicable.
Microshift Test Compatibility ✅ Passed The pull request does not add any new Ginkgo e2e tests requiring MicroShift compatibility assessment; only existing tests are modified.
Single Node Openshift (Sno) Test Compatibility ✅ Passed Pull request does not add new Ginkgo e2e tests; only updates dependencies and modifies existing integration test.
Topology-Aware Scheduling Compatibility ✅ Passed PR only modifies go.mod dependencies and fixes a test timing issue; contains no deployment manifests, operator code, or scheduling constraints.
Ote Binary Stdout Contract ✅ Passed Pull request modifies only go.mod and test file; polling logic added within test function is exempt from OTE Binary Stdout Contract.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed The PR adds standard Go integration tests using testing.T, not Ginkgo e2e tests with It()/Describe()/Context()/When() patterns, so the check does not apply.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 16, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DavidHurta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 16, 2026
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Apr 16, 2026 •
edited by openshift-ci Bot
Loading

@DavidHurta: This pull request references OTA-1836 which is a valid jira issue.

Details

In response to this:

The API update is needed for the new TLS adherence API and other efforts.

Other general openshift packages are updated as well for periodic maintenance. We might as well update those while we are at it. De facto a clone of the #1346 PR.

Generated by:

$ go get github.com/openshift/api@master
$ go get github.com/openshift/client-go@master
$ go get github.com/openshift/library-go@master
$ go mod tidy
$ go mod vendor
$ git add -A go.* vendor

using:

$ go version
go version go1.25.0 linux/amd64

Summary by CodeRabbit

  • Chores
  • Updated OpenShift Go dependencies to newer versions for improved compatibility and stability.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@DavidHurta DavidHurta mentioned this pull request Apr 16, 2026
Closed
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Apr 16, 2026 •
edited by openshift-ci Bot
Loading

@DavidHurta: This pull request references OTA-1836 which is a valid jira issue.

Details

In response to this:

The API update is needed for the new TLS adherence API and other efforts.

Other general openshift packages are updated as well for periodic maintenance. We might as well update those while we are at it. De facto an updated clone of the #1346 PR.

Generated by:

$ go get github.com/openshift/api@master
$ go get github.com/openshift/client-go@master
$ go get github.com/openshift/library-go@master
$ go mod tidy
$ go mod vendor
$ git add -A go.* vendor

using:

$ go version
go version go1.25.0 linux/amd64

Summary by CodeRabbit

  • Chores
  • Updated OpenShift Go dependencies to newer versions for improved compatibility and stability.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@DavidHurta
Copy link
Copy Markdown
Contributor Author

DavidHurta commented Apr 16, 2026

/label acknowledge-critical-fixes-only

This is blocking everything, which may need an updated Openshift API. The branch cut has occurred, so I am okay with updating these dependencies if the CI passes.

@openshift-ci openshift-ci Bot added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label Apr 16, 2026
@DavidHurta
Copy link
Copy Markdown
Contributor Author

DavidHurta commented Apr 17, 2026

/retest-required

1 similar comment
@DavidHurta
Copy link
Copy Markdown
Contributor Author

DavidHurta commented Apr 20, 2026

/retest-required

@DavidHurta
Copy link
Copy Markdown
Contributor Author

DavidHurta commented Apr 20, 2026

Let me investigate the agnostic-operator.

/hold

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 20, 2026
@DavidHurta
Copy link
Copy Markdown
Contributor Author

DavidHurta commented Apr 23, 2026

/test e2e-agnostic-operator

@DavidHurta @claude
fix: Add polling for leader election event in TestIntegrationCVO_grac…
2ff8337 
…efulStepDown

Fix race condition where the test immediately checked for leader
election events without polling, causing intermittent failures when
event propagation took longer than expected.

The fix adds proper polling logic (wait.PollUntilContextTimeout) to wait
up to 10 seconds for the leader election event to become visible via the
Events API, matching the pattern already used for lock acquisition
verification in the same test.

This issue was exposed by a recent dependency bump which likely
changed timing characteristics in the OpenShift libraries, making event
propagation delays more visible.

Co-authored-by: Claude Code <claude@anthropic.com>
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 23, 2026

@DavidHurta: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-hypershift-conformance 2ff8337 link true /test e2e-hypershift-conformance
ci/prow/e2e-hypershift 2ff8337 link true /test e2e-hypershift
ci/prow/e2e-aws-ovn-techpreview 2ff8337 link true /test e2e-aws-ovn-techpreview

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@DavidHurta @openshift-ci-robot